[patch] PR 12999 info macros command.

Tom Tromey tromey@redhat.com
Thu Jul 21 14:07:00 GMT 2011


>>>>> "Matt" == Matt Rice <ratmice@gmail.com> writes:

Matt> Updated the docs, and the 'help' command text for 'info definitions'.
Matt> I added @cindex macros, from debug info
Matt> so it would be near the existing @cindex macros, user-defined

Two more nits...

Matt> +  if (! name || ! *name)
Matt> +    error (_("The `info definitions' command requires a macro name as an \
Matt> +argument.\n"
Matt> +           "Usage: info definitions MACRO\n"));

I think "usage" lines should be in the help text, but not in errors.
So, please remove it here.
Also, errors should not end with \n.

Matt> +  add_cmd ("macros", no_class, info_macros_command,
Matt> +	   _("Show the definitions of all macros at LINESPEC, or the current \
Matt> +source location.\n\
Matt> +Usage: info source [LINESPEC]"),

Typo: s/source/macros/

This is ok with those changes.

Tom



More information about the Gdb-patches mailing list