[Patch] More responsive QUITs

Sterling Augustine saugustine@google.com
Wed Jul 13 03:03:00 GMT 2011


Hello,

Enclosed is a patch that adds calls to QUIT in various places which
makes GDB more responsive to CTRL-C. In particular, reading a symbol
file at start up can now be interrupted (although perhaps still not as
responsive as one might like), as well as various other long running
operations. I know at least two GDB developers have one or another of
these on their TODO lists.

All three of these calls to QUIT have relatively close cleanup handlers:

The new call in dwarf2_build_psymtabs is cleaned up by the handlers in
the same function.
Likewise for the new call in process_type_comp_unit, which is just a
level or two down.

The new call in map_symbol_filenames_psymtab occurs in a location
where I don't believe there could be any inconsistent state.

Comments?

Sterling

=-=-=-=-=-
2011-07-12  Sterling Augustine  <saugustine@google.com>

	* dwarf2read.c (process_type_comp_unit): Call QUIT.
	(dwarf2_build_psymtabs_hard): Likewise.
	* psymtab.c (map_symbol_filenames_psymtab): Likewise.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: quit.patch
Type: text/x-patch
Size: 1127 bytes
Desc: not available
URL: <http://sourceware.org/pipermail/gdb-patches/attachments/20110713/90ea60c9/attachment.bin>


More information about the Gdb-patches mailing list