[RFA] Make ppc-linux-nat insert/remove breakpoint and watchpoint functions return -1.

Tom Tromey tromey@redhat.com
Wed Jul 6 15:03:00 GMT 2011


>>>>> "Thiago" == Thiago Jung Bauermann <bauerman@br.ibm.com> writes:

Thiago> target_{insert,remove}_{hw_breakpoint,watchpoint,mask_watchpoint} are
Thiago> supposed to return 0, 1 and -1 for success, unsupported and error,
Thiago> respectively.

I looked around for anything saying this, and couldn't find it.
Well -- I found it for target_insert_mask_watchpoint, but not other
cases.

And, at least in breakpoint.c:insert_bp_location, it seems to me that
the return value is expected to be an errno in one case -- search for
safe_strerror.

Maybe this code is in error?  I really couldn't say; but it seems
inconsistent at best.  Perhaps only parts of your patch could go in
as-is, what do you think?

Tom



More information about the Gdb-patches mailing list