[PATCH,gdb]: ensures that cie ptr of an fda is a cie
Tom Tromey
tromey@redhat.com
Tue Jul 5 16:26:00 GMT 2011
>>>>> "Fawzi" == Fawzi Mohamed <fawzi.mohamed@nokia.com> writes:
Fawzi> +enum eh_frame_type {
Fawzi> + eh_cie_type_id = 1,
Fawzi> + eh_fde_type_id = 2,
Fawzi> + eh_cie_or_fde_type_id = 3
I think enum constant names should be all caps.
That is the usual style.
Fawzi> + gdb_assert ((entry_type & eh_cie_type_id)!=0);
It seems to me that this code is attempting to validate user input. If
so, an assertion is incorrect -- instead it should call either error or
warning and in the latter case also arrange for the bad data to be
ignored.
Tom
More information about the Gdb-patches
mailing list