FYI: add user_breakpoint_p

Joel Brobecker brobecker@adacore.com
Mon Jan 31 02:10:00 GMT 2011


> 2011-01-27  Tom Tromey  <tromey@redhat.com>
> 
> 	* breakpoint.h (user_breakpoint_p): Declare.
> 	* breakpoint.c (user_breakpoint_p): New function.
> 	(breakpoint_1): Use it.
> 	(save_breakpoints): Likewise.

I love these little cleanups :-).

Just one question about style:

> -    if (!user_settable_breakpoint (tp) || tp->number < 0)
> +    if (! user_breakpoint_p (tp))

Do we agree on whether to write this as the above, or whether we should
not have a space between the '!' and the expression being negated:

   if (! user_breakpoint_p (tp))

?

I did a rough count, and currently we have a bout 500 instance with the
space, and 2800 without...

-- 
Joel



More information about the Gdb-patches mailing list