[RFA v2] valprint.c / *-valprint.c: Don't lose `embedded_offset'

Tom Tromey tromey@redhat.com
Fri Jan 28 11:35:00 GMT 2011


>>>>> "Pedro" == Pedro Alves <pedro@codesourcery.com> writes:

Pedro> In the context of tracepoints, I'm adding support for
Pedro> partial/incomplete objects.

This sound tantalizingly close to the sparse value thing we were talking
about recently.

Pedro> The comment is actually not 100% correct or clear.  It's actually
Pedro> data of type TYPE located at VALADDR + EMBEDDED_OFFSET, which
Pedro> came from the inferior at address ADDRESS + EMBEDDED_OFFSET.
Pedro> ORIGINAL_VALUE, if non-NULL, is what came from ADDRESS.  (the
Pedro> patch doesn't fix this; there are a bunch of copies of that
Pedro> comment around, and I want to fix them all in one go in a
Pedro> followup, or maybe in a next revision of this patch).

Or maybe nuke them all and have a single comment describing the
"val_print protocol" somewhere.  These duplicated comments always end up
rotting.

Thanks for doing this.

Tom



More information about the Gdb-patches mailing list