[patch] Shorten lines of >= 80 columns.
Michael Snyder
msnyder@vmware.com
Thu Jan 6 18:05:00 GMT 2011
Joel Brobecker wrote:
>> internal_error (__FILE__, __LINE__,
>> _("gen_var_ref: LOC_CONST_BYTES "
>> "symbols are not supported"));
>
> For one-line strings, I think that's an acceptable solution. In fact,
> this might be a better solution, making the code as a whole more
> readable (because it avoids the misindentation of the string that breaks
> the formatting of the code as a whole).
>
> For multi-line strings, such as help strings, etc, I think it will be
> easier to still use the style that you originally chose. For instance:
>
> | warning (_("\
> | Private mapping of shared library text was not specified\n\
> | by the executable; setting a breakpoint in a shared library which\n\
> | is not privately mapped will not work. See the HP-UX 11i v3 chatr\n\
> | manpage for methods to privately map shared library text."));
>
> I think that, for multi-line strings, this makes easier to read the
> entire text, and it also makes it easier to make sure that the string
> is of reasonable size (ie, under 80, or 76, or 74).
>
> The typical case where these are used are the _init routines, where
> we create new commands. The help strings can easily need to have
> more than one line (if it was me, I would put as much information
> in the help command as in the manual).
Yeah, you're right. I'll try to put some of them back.
More information about the Gdb-patches
mailing list