[rfa] add_symbol_file_command, avoid memory leak.

Michael Snyder msnyder@vmware.com
Sun Feb 27 22:00:00 GMT 2011


Jan Kratochvil wrote:
> On Sun, 27 Feb 2011 21:35:46 +0100, Michael Snyder wrote:
>> Jan Kratochvil wrote:
>>> While a nitpick it is a regression, that dont_repeat should be called even
>>> in the case of that error.
>> No, it's a fix.  I moved the error before dont_repeat.
> 
> Why?  The manual says:
> 	`add-symbol-file' does not repeat if you press <RET> after using it.
> Other part of the manual says:
> 	and you can repeat certain GDB commands by typing just <RET>.
> 
> There is nothing said that whether the command is / is not repated depends on
> its entered arguments.
> 
> (Not sure if it matters to continue the discussion, I do not mind either way.)

Ah, sorry, I misunderstood you.  I'm with you now.

How about this?



-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: symfile2.txt
URL: <http://sourceware.org/pipermail/gdb-patches/attachments/20110227/961a673f/attachment.txt>


More information about the Gdb-patches mailing list