[commit/testsuite] small py-breakpoint.exp cleanups

Joel Brobecker brobecker@adacore.com
Tue Feb 22 16:43:00 GMT 2011


I looked a bit at this testcase, and notice a few things that were
easy to fix:

  - prepare_for_testing already does a clean_restart, so calling
    prepare_for_testing just after it was useless.  Removed.

  - We have a "print result" test whose expected output was "545".
    I thought that we could make it safer by integrating the equal
    sign in the expected output: " = 545".

  - Just a tiny typo in one of the comments.

I also noticed that the test comments are not unique, which is not
a huge issue, but it does make it harder to analyze the results.
But there are so many tests, and I didn't have the time today to
take care of that.

gdb/testsuite/ChangeLog:

        * gdb.python/py-breakpoint.exp: Remove unnecessary call to
        clean_restart.  Be a little stricter in the expected output
        for one of the tests.  Fix a typo in one of the comments.

Tested on x86_64-linux, checked in.

---
 gdb/testsuite/ChangeLog                    |    6 ++++++
 gdb/testsuite/gdb.python/py-breakpoint.exp |    7 ++-----
 2 files changed, 8 insertions(+), 5 deletions(-)

diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog
index 46225c0..5d524d4 100644
--- a/gdb/testsuite/ChangeLog
+++ b/gdb/testsuite/ChangeLog
@@ -1,5 +1,11 @@
 2011-02-22  Joel Brobecker  <brobecker@adacore.com>
 
+	* gdb.python/py-breakpoint.exp: Remove unnecessary call to
+	clean_restart.  Be a little stricter in the expected output
+	for one of the tests.  Fix a typo in one of the comments.
+
+2011-02-22  Joel Brobecker  <brobecker@adacore.com>
+
 	* gdb.python/py-block.exp: Simplify using prepare_for_testing.
 	Delete variable binfile, no longer use.  Add or modify test
 	comments to make them unique.
diff --git a/gdb/testsuite/gdb.python/py-breakpoint.exp b/gdb/testsuite/gdb.python/py-breakpoint.exp
index 6b33284..b9f8c4a 100644
--- a/gdb/testsuite/gdb.python/py-breakpoint.exp
+++ b/gdb/testsuite/gdb.python/py-breakpoint.exp
@@ -28,9 +28,6 @@ if { [prepare_for_testing ${testfile}.exp ${testfile} ${srcfile}] } {
     return -1
 }
 
-# Start with a fresh gdb.
-clean_restart ${testfile}
-
 # Skip all tests if Python scripting is not enabled.
 if { [skip_python_tests] } { continue }
 
@@ -64,7 +61,7 @@ gdb_test "python print blist\[1\].hit_count" "1" "Check breakpoint hit count"
 gdb_py_test_silent_cmd "python blist\[1\].ignore_count = 4" "Set breakpoint hit count" 0
 gdb_continue_to_breakpoint "Break at multiply."
 gdb_test "python print blist\[1\].hit_count" "6" "Check breakpoint hit count"
-gdb_test "print result" "545" "Check expected variable result after 6 iterations"
+gdb_test "print result" " = 545" "Check expected variable result after 6 iterations"
 
 # Test breakpoint is enabled and disabled correctly..
 gdb_breakpoint [gdb_get_line_number "Break at add."]
@@ -148,7 +145,7 @@ if ![runto_main] then {
     return 0
 }
 
-# Test invisible breakpooints.
+# Test invisible breakpoints.
 delete_breakpoints
 set ibp_location [gdb_get_line_number "Break at multiply."]
 gdb_py_test_silent_cmd  "python ibp = gdb.Breakpoint(\"$ibp_location\", internal=False)" "Set invisible breakpoint" 0
-- 
1.7.1



More information about the Gdb-patches mailing list