RFC: move agent opcodes to common file

Tom Tromey tromey@redhat.com
Thu Feb 17 15:13:00 GMT 2011


>>>>> ">" == Hui Zhu <teawater@gmail.com> writes:

>> And I have a question is if the common/ax.def updated, will the
>> ax-general.c, gdbserver/tracepoint.c and file that use the ax.h
>> rebuild?

Thanks -- I forgot to update the dependencies in gdbserver/Makefile.in.
Maybe I should finish my patch to convert gdbserver to automake :-)
gdb has automatic dependency tracking, so that part will just work.

>> I want try this patch with myself but looks your add the new op
>> aop_pick = 0x31, aop_rot = 0x32.

Yeah, it is based on my earlier patch.  It is pretty easy to apply this
and fix the conflicts though.

>> BTW I have use the op 31 to be the op_printf in my printf patch and
>> kgtp new release version.

>> If your software(I think is SystemTap, right?) that use aop_pick =
>> 0x31, aop_rot = 0x32 is not release, could you let op_printf use the
>> op 31?

Sorry about that -- I meant to leave a gap for your opcode, but then I
forgot to actually do it.  I fixed this locally.

While I am working on some SystemTap-related functionality, this patch
is independent from that.

This patch just lets us translate a few more DWARF opcodes to AX.  Of
these, right now GCC only actually generates DW_OP_over.  I just looked
at GCC and it seems that the current translation code does not handle
all the uses of DW_OP_over that GCC can emit.

Tom



More information about the Gdb-patches mailing list