[trunk + 7.4] fix erroneous comparison in filter_sals

Tom Tromey tromey@redhat.com
Fri Dec 16 21:34:00 GMT 2011


I'm checking this in on the trunk and the 7.4 branch.

Debugging ambiguous linespec regressions on PPC showed that this
conditional was partially reversed.

Built and regtested on x86-64 F15 and PPC (gcc110, some version of
Debian -- btw this is a nice 64-way box, very fast builds there).

Tom

2011-12-16  Tom Tromey  <tromey@redhat.com>

	* cli/cli-cmds.c (filter_sals): Filter out sals with NULL symtab.

Index: cli/cli-cmds.c
===================================================================
RCS file: /cvs/src/src/gdb/cli/cli-cmds.c,v
retrieving revision 1.120
diff -u -r1.120 cli-cmds.c
--- cli/cli-cmds.c	6 Dec 2011 18:54:40 -0000	1.120
+++ cli/cli-cmds.c	16 Dec 2011 21:17:08 -0000
@@ -1516,7 +1516,7 @@
   for (i = 0; i < sals->nelts; ++i)
     {
       if (sals->sals[i].pspace == current_program_space
-	  || sals->sals[i].symtab == NULL)
+	  && sals->sals[i].symtab != NULL)
 	{
 	  sals->sals[out] = sals->sals[i];
 	  ++out;



More information about the Gdb-patches mailing list