[patch] GDB 7.2: new feature for "backtrace" that cuts path to file (remain filename)

[iam ahal]

To Tom Tromey, Doug Evans:

Sorry for a late response, unfortunately, I've been busy at work.
Thanks for the review. I've checked and corrected the patch by your
comments.
See changed files in the attachment.

On Wed, Nov 2, 2011 at 11:05 PM, Tom Tromey <tromey@redhat.com> wrote:
> I don't recall whether this has had a doc review yet.

You have not reviewed a text for this feature in the documentation.

> I think the patch should also include a NEWS entry.

I don't have an idea how to fill out a NEWS entry. It has descriptions
only for release versions.

On Thu, Nov 3, 2011 at 2:53 AM, Doug Evans <dje@google.com> wrote:
> If filename_display is NULL it's because sal.symtab->filename was NULL.
> [right?]
> This is confusing.
> I suggest removing this code:
>
> +      if (filename_display == NULL)
> +         filename_display = sal.symtab->filename;

I leave this check because I suppose that we don't need to know how to
work this function.
So I don't need to know when it can return NULL.
It's reliable in a sense that everybody can modify this function (e.g.
I can add new cases when it returns NULL).

~Eldar.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: gdb-filename-display.patch
Type: text/x-patch
Size: 6089 bytes
Desc: not available
URL: <http://sourceware.org/pipermail/gdb-patches/attachments/20111204/9e414002/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: ChangeLog
Type: application/octet-stream
Size: 796 bytes
Desc: not available
URL: <http://sourceware.org/pipermail/gdb-patches/attachments/20111204/9e414002/attachment.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: ChangeLog-doc
Type: application/octet-stream
Size: 166 bytes
Desc: not available
URL: <http://sourceware.org/pipermail/gdb-patches/attachments/20111204/9e414002/attachment-0001.obj>