[RFA 4/8] New port: TI C6x: Read loadmap from gdbserver

[Yao Qi]

On 08/08/2011 08:30 AM, Mike Frysinger wrote:
> On Monday, July 25, 2011 00:27:50 Yao Qi wrote:
>> On 07/22/2011 10:16 AM, Mike Frysinger wrote:
>>>> +#if defined __DSBT__
>>>> +static int
>>>
>>> rather than being tied to the exec format that *gdbserver* is being
>>> built as, shouldnt this be bound to the ptrace defines being available
>>> ?  how abut using "#ifdef PTRACE_GETDSBT" ?
>>
>> Yeah, that makes sense.  Done.
> 
> i think you missed a spot.  one place uses __DSBT__ while another uses 
> PTRACE_GETDSBT.

Yes, I thought it is not quite related to PTRACE stuff, so I didn't
change that.  I agree that we should use macros in a consistent way.  I
replace PTRACE_GETDSBT and __DSBT__ with PT_GETDSBT, because PT_GETDSBT
is defined in sys/ptrace.h, but PTRACE_GETDSBT is defined in asm/ptrace.h.

> 
>> +    addr= (int) PTRACE_GETDSBT_EXEC;
>> +  else if (strcmp (annex, "interp") == 0)
>> +    addr =(int) PTRACE_GETDSBT_INTERP;
> 
> there needs to be one space before and after the "=" here

oh, thanks, fixed.

-- 
Yao (齐尧)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0004-fdpic-packet-and-dsbt.patch
Type: text/x-patch
Size: 9028 bytes
Desc: not available
URL: <http://sourceware.org/pipermail/gdb-patches/attachments/20110808/87518708/attachment.bin>