[RFC] Add patches from Chromium OS gdb

Tom Tromey tromey@redhat.com
Tue Aug 2 14:26:00 GMT 2011


>>>>> "Caroline" == Caroline Tice <cmtice@google.com> writes:

Caroline> This patch combines two patches from the Chromium OS gdb.  The first
Caroline> patch conditionally includes <wchar.h> in several readline files.

I think readline fixes should be sent upstream first.  If the readline
maintainer agrees to them, then we can put them in our tree.

However, are they really needed?  In the current tree, the readline
source files include rlmbutil.h, which includes wchar.h.

Caroline> this is because gdb/Makefile contains no explicit -I path to
Caroline> the toplevel, and --with-system-readline disables the implicit
Caroline> -I path

I tried a build using --with-system-readline, and it worked fine for me.
So I think something else must be going on.

Tom



More information about the Gdb-patches mailing list