[RFC] Fixing gdb.base/completion.exp (PR testsuite/12649)
Joel Brobecker
brobecker@adacore.com
Wed Apr 27 15:05:00 GMT 2011
> Thus, my point is that we could replace those "send_gdb + sleep +
> gdb_expect" sequences with just one gdb_test{,multiple,no_output}. I
> don't know yet if this transformation is possible for every test in
> the completion.exp file. Maybe the changes would be quite dramatical.
> However, this test would be _much_ simpler and much faster. Also, the
> current formatting is ugly ;).
>
> So, do you think this is a good idea? Is there something I'm missing?
I don't know the history of the testcase, and this is only my own
opinion, but I tend to agree with you. I think we should keep one
test with \t, to make sure that a tab does trigger the completion,
but the rest of the testcase should be using the "complete" command.
That's what we do at AdaCore anyways...
--
Joel
More information about the Gdb-patches
mailing list