[RFC-v5] Handle cygwin wchar_t specifics

Tom Tromey tromey@redhat.com
Wed Apr 20 20:21:00 GMT 2011


>>>>> "Pierre" == Pierre Muller <pierre.muller@ics-cnrs.unistra.fr> writes:

Pierre>   Hopefully I got it right this time...
 
Just a tiny nit left :)
Thanks for persevering.

Pierre> +  const char *result;

You can make this one just a "char *".
That will let you avoid casts in the xfree calls.

Pierre> +  error ("Unable to find a vaild charset for string conversions");

Needs _().

Ok with those changes.

Tom



More information about the Gdb-patches mailing list