Fix for: "/usr/bin/install: cannot stat `libinproctrace.so': No such file or directory"

[Pedro Alves]

On Thursday 02 September 2010 23:12:46, Paralkar Anmol-B07584 wrote:
> Hello Michael,
> 
>  Sorry! Please see the (attached) re-spun patch.

Hi!  Thanks for spotting this.

> *************** install: all install-only
> *** 167,173 ****
>   install-only:
>   	n=`echo gdbserver | sed '$(program_transform_name)'`; \
>   	if [ x$$n = x ]; then n=gdbserver; else true; fi; \
> ! 	if [ x$IPA_DEPFILES != x ]; then \
>   		$(SHELL) $(srcdir)/../../mkinstalldirs $(DESTDIR)$(libdir); \
>   		$(INSTALL_PROGRAM) $(IPA_LIB) $(DESTDIR)$(libdir)/$(IPA_LIB); \
>   	fi; \
> --- 167,173 ----
>   install-only:
>   	n=`echo gdbserver | sed '$(program_transform_name)'`; \
>   	if [ x$$n = x ]; then n=gdbserver; else true; fi; \
> ! 	if [ x$$IPA_DEPFILES != x ]; then \
>   		$(SHELL) $(srcdir)/../../mkinstalldirs $(DESTDIR)$(libdir); \
>   		$(INSTALL_PROGRAM) $(IPA_LIB) $(DESTDIR)$(libdir)/$(IPA_LIB); \
>   	fi; \


This however isn't correct.  The intent is not to make the variable reference visible
to the shell (it'd always be empty), but to expand it before the shell sees it.

I've applied this patch below to fix this, after confirming "make install" does install
the library on a amd64-linux build.  I'll apply this to the 7.2 branch as well shortly.

2010-09-06  Pedro Alves  <pedro@codesourcery.com>

	* Makefile.in (install-only): Replace $IPA_DEPFILES with
	"$(IPA_DEPFILES)".

---
 gdb/gdbserver/Makefile.in |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Index: src/gdb/gdbserver/Makefile.in
===================================================================
--- src.orig/gdb/gdbserver/Makefile.in	2010-09-06 11:28:19.000000000 +0100
+++ src/gdb/gdbserver/Makefile.in	2010-09-06 11:42:54.000000000 +0100
@@ -167,7 +167,7 @@ install: all install-only
 install-only:
 	n=`echo gdbserver | sed '$(program_transform_name)'`; \
 	if [ x$$n = x ]; then n=gdbserver; else true; fi; \
-	if [ x$IPA_DEPFILES != x ]; then \
+	if [ x"$(IPA_DEPFILES)" != x ]; then \
 		$(SHELL) $(srcdir)/../../mkinstalldirs $(DESTDIR)$(libdir); \
 		$(INSTALL_PROGRAM) $(IPA_LIB) $(DESTDIR)$(libdir)/$(IPA_LIB); \
 	fi; \