FYI: change type searching

Daniel Jacobowitz dan@codesourcery.com
Mon Sep 6 08:55:00 GMT 2010


On Wed, Sep 01, 2010 at 03:43:56PM -0600, Tom Tromey wrote:
> I'm checking this in.

Did you test this using GCC 4.5?  It appears to regress temargs.exp.
Specifically, this bit:

> @@ -1051,7 +1051,7 @@ lookup_typename (const struct language_defn *language,
>    struct symbol *sym;
>    struct type *tmp;
>  
> -  sym = lookup_symbol (name, block, VAR_DOMAIN, 0);
> +  sym = lookup_type_symbol (name, block, VAR_DOMAIN, language->la_language);
>    if (sym == NULL || SYMBOL_CLASS (sym) != LOC_TYPEDEF)
>      {
>        tmp = language_lookup_primitive_type_by_name (language, gdbarch, name);

lookup_symbol can find the Base<....> type.  lookup_type_symbol does
not find it.

> All of this searching is pointless, though, because types are made
> static, not public.

I don't know what you mean by this.  If you mean in our symbol lists,
then that's not true; C++ types go in the global list.

-- 
Daniel Jacobowitz
CodeSourcery



More information about the Gdb-patches mailing list