[patch 2/2] Overload resolution among children of a common ancestor

Tom Tromey tromey@redhat.com
Fri Oct 22 17:16:00 GMT 2010


>>>>> "Sami" == sami wagiaalla <swagiaal@redhat.com> writes:

Sami> This patch does the quoted above, but through a subrank field int the
Sami> newly created rank struct. This prevents the ranking amongst children
Sami> of a common ancestor from interfering with other rankings.

This looks good.

Sami>  /* Struct used to store conversion rankings.  */
Sami>  struct rank
Sami>    {
Sami> -    int rank;
Sami> +    short rank;
Sami> +    short subrank;

I think the subrank field should have a comment explaining its purpose.

This is ok with that change, with whatever minor changes are needed to
account for the changes to patch #1.

Tom



More information about the Gdb-patches mailing list