[RFA] Rework symbol searches to move Ada-specific stuff to ada-lang.c.
Tom Tromey
tromey@redhat.com
Thu Oct 7 17:53:00 GMT 2010
>>>>> "Paul" == Paul Hilfinger <HIlfinger@cs.berkeley.edu> writes:
Paul> + return (*top);
Tom> A few places have parens here, but they aren't needed.
Tom> Just write "return *top;".
Paul> OK (BTW: That line was copied from the original).
Oh, ok. I had looked to see if this was the case, but I must have
missed it.
My view is that it is always ok to leave code as-is when moving it
around. I recommend pushing back on reviewers who ask for changes to
the context of a patch :-)
Tom
More information about the Gdb-patches
mailing list