[patch] initial OpenCL C language support

[Ken Werner]

On Thursday, November 04, 2010 6:48:07 pm Eli Zaretskii wrote:
> > From: Ken Werner <ken@linux.vnet.ibm.com>
> > Date: Thu, 4 Nov 2010 16:38:45 +0100
> > Cc: Tom Tromey <tromey@redhat.com>, Eli Zaretskii <eliz@gnu.org>,
> > 
> >         gdb-patches@sourceware.org
> > 
> > Attached is a patch that adds a few bits to the documentation and the
> > NEWS file.
> 
> Thanks.
> 
> > +by OpenCL 1.1.  In addition the half- and double-precision floating
> > point +data types of the cl_khr_fp16 and cl_khr_fp64 OpenCL extensions
> > are also +known to @value{GDBN}.
> 
> cl_khr_fp16 and cl_khr_fp64 should probably be in @code.

Done.

> > +@value{GDBN} supports accesses to vector components including the access
> > as +lvalue where possible. Since OpenCL C is based on C99 most C
> > expressions
> 
>                         ^^
> Two spaces, please.

Fixed.

> > --- src.orig/gdb/NEWS	2010-11-04 14:14:25.000000000 +0100
> > +++ src/gdb/NEWS	2010-11-04 14:18:33.000000000 +0100
> > @@ -3,6 +3,9 @@
> > 
> >  *** Changes since GDB 7.2
> > 
> > +* OpenCL C
> > +  Initial support for the OpenCL C language has been integrated into
> > GDB. +
> 
> This part is fine, but I'd suggest to add a link to the OpenCL site
> here.

Added.

> Okay with those changes.

Thanks. Attached is the updated patch.
I think the documentation patch should be checked in together with the main 
OpenCL C language patch. I'll merge this one into the main patch prior to 
commiting.

Regards
Ken
-------------- next part --------------
A non-text attachment was scrubbed...
Name: opencl-lang-doc.patch
Type: text/x-patch
Size: 3468 bytes
Desc: not available
URL: <http://sourceware.org/pipermail/gdb-patches/attachments/20101105/9e0f13c5/attachment.bin>