[PATCH] skip break-entry.exp when using a stub
Michael Snyder
msnyder@vmware.com
Tue Nov 2 18:04:00 GMT 2010
Joel Brobecker wrote:
>> -Nathan
>>
>> * gdb.base/break-entry.exp: Skip if using a stub.
>
> I am not sure about one detail:
>
>> +# If we're using a stub, we'll already be stopped at the entry point
>> +# when we connect. Don't bother trying to work around this in the
>> +# testing below.
>> +
>> +if [target_info exists use_gdb_stub] {
>> + untested ${testfile}.exp
>> + return
>> +}
>
> I am not sure that the use of "untested" is correct, here. Looking
> at the dejagnu documentation:
>
> UNTESTED
> A test was not run. This is a placeholder, used when there is no
> real test case yet.
>
> untested "string"
> Declares a test was not run. untested writes in the log file
> a message beginning with `UNTESTED', appending the argument
> string. For example, you might use this in a dummy test whose
> only role is to record that a test does not yet exist for some
> feature.
>
> Perhaps we just ought to `return' directly. What do others think?
>
Yes, that's what I'd do.
More information about the Gdb-patches
mailing list