[RFA] windows-nat.c: Copy console information for new console

Christopher Faylor cgf-use-the-mailinglist-please@sourceware.org
Wed May 26 17:20:00 GMT 2010


On Wed, May 26, 2010 at 09:49:05AM +0200, Pierre Muller wrote:
>> -----Message d'origine-----
> De?: gdb-patches-owner@sourceware.org [mailto:gdb-patches-
>> owner@sourceware.org] De la part de Christopher Faylor
>> I don't mind the concept but this function is becoming pretty big so I
>> would appreciate it if you would move all of the logic into a function.
>> Maybe call it "set_console_info()" and pass it &flags, &si.
>> 
>> cgf
>
>
>  You are right, this is cleaner, nevertheless flags isn't
>used much,

I actually thought fairly carefully about flags.  If you have a function
which controls console info, then the function should set the flags
appropriately to deal with the console info.

cgf



More information about the Gdb-patches mailing list