[resubmit] gdb.base, r*.exp thru w*.exp

Michael Snyder msnyder@vmware.com
Thu May 20 21:46:00 GMT 2010


Jan Kratochvil wrote:
> On Thu, 20 May 2010 22:29:47 +0200, Michael Snyder wrote:
>> +	-re ".*in main after func1.*$gdb_prompt $" { 
> 
> Sorry for not a complete review but for this case there should be:
> 
> 	-re ".*in main after func1.*\r\n$gdb_prompt $" { 
> 
> or lib/gdb.exp proc gdb_test is using:
> 
> 	-re ".*in main after func1.*[\r\n]+$gdb_prompt $" { 
> 
> as just "$gdb_prompt $" is needlessly  weak in practical cases causing false
> positives.

Thanks for the review -- but I don't follow you.

What is it about this particular case that you think requires
disambiguating?  Or are you saying this in general?




More information about the Gdb-patches mailing list