[PATCH] Tracepoint action validation cleanup

[Stan Shebs]

Nathan started it as a simple error message rationalization, I went a 
little overboard from there. :-)  The most notable part of the change is 
that validate_actionline no longer returns a result.  The original 
theory was it would analyze tracepoint actions and return a thumbs 
up/down, but in practice most kinds of problems result in a call to 
error() , and so there was little use for a return value.

There is certainly more that could be done, but this is a well-defined 
step in the right direction.

Stan

2010-03-31  Stan Shebs  <stan@codesourcery.com>
        Nathan Sidwell  <nathan@codesourcery.com>

    * tracepoint.h (enum actionline_type): Remove.
    (validate_actionline): Change return to void.
    * tracepoint.c (report_agent_reqs_errors): New function.
    (validate_actionline): Call it, change return to void, report errors
    more consistently.
    (collect_symbol): Call report_agent_reqs_errors.
    (encode_actions_1): Ditto.
    (encode_actions): Don't expect a result from validate_actionline.


    * gdb.trace/actions.exp: Tweak expected output.
    * gdb.trace/while-stepping.exp: Tweak expected output.

-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: errmsgs-patch-1
URL: <http://sourceware.org/pipermail/gdb-patches/attachments/20100331/e1fdd9d9/attachment.ksh>