[cancel] Re: [patch] Fix crash on NULL rl_prompt

Jan Kratochvil jan.kratochvil@redhat.com
Wed Mar 31 21:27:00 GMT 2010


On Tue, 30 Mar 2010 19:55:08 +0200, Pedro Alves wrote:
> On Tuesday 30 March 2010 18:30:48, Tom Tromey wrote:
> > We can always un-approve it, if you would rather wait to see if a
> > reproducer is available.
> 
> I'll leave it up to you to decide.  But if this goes in,
> perhaps a comment saying this is being defensive would be good.

Found the problem was most probably due to a Fedora patch posted here without
the FSF GDB acceptance intention:
	[gdb FYI-patch] callback-mode readline-6.0 regression
	http://sourceware.org/ml/gdb-patches/2009-11/msg00596.html

That patch is needed only with readline-6.0 and neither with 5.1 nor 6.1.
That patch accidentally did rl_set_prompt (NULL).

(FSF GDB should import readline-6.1 but that is offtopic in this thread.)

Therefore not going to check-in this patch.


Thanks,
Jan



More information about the Gdb-patches mailing list