Don't allow switching on the TUI in some cases

Pedro Alves pedro@codesourcery.com
Wed Mar 31 11:47:00 GMT 2010


On Wednesday 31 March 2010 08:30:02, Eli Zaretskii wrote:
> > From: Pedro Alves <pedro@codesourcery.com>
> > Date: Tue, 30 Mar 2010 23:23:40 +0100
> > 
> >  void
> >  tui_enable (void)
> >  {
> > +  if (!tui_allowed_p ())
> > +    error (_("TUI mode not allowed"));
> > +
> 
> Does this need a suitable change for the manual?  We currently say
> this in the "TUI Commands" node:
> 
>     The TUI has specific commands to control the text windows.  These
>     commands are always available, even when GDB is not in the TUI mode.
>     When GDB is in the standard mode, most of these commands will
>     automatically switch to the TUI mode.
> 
> Looks like this is no longer true with this patch, is that right?

I had considered it and thought it could be more noise
than signal to extend that, but, maybe if I keep it a separate
paragraph it's okay.  How about this?

-- 
Pedro Alves

2010-03-31  Pedro Alves  <pedro@codesourcery.com>

	gdb/doc/
	* gdb.texinfo (TUI Commands): Mention that in some cases, these
	commands error out.

---
 gdb/doc/gdb.texinfo |    6 ++++++
 1 file changed, 6 insertions(+)

Index: src/gdb/doc/gdb.texinfo
===================================================================
--- src.orig/gdb/doc/gdb.texinfo	2010-03-31 12:32:17.000000000 +0100
+++ src/gdb/doc/gdb.texinfo	2010-03-31 12:42:53.000000000 +0100
@@ -21653,6 +21653,12 @@ These commands are always available, eve
 the TUI mode.  When @value{GDBN} is in the standard mode, most
 of these commands will automatically switch to the TUI mode.
 
+Note that if @value{GDBN}'s @code{stdout} is not connected to a
+terminal, or @value{GDBN} has been started with the machine interface
+interpreter (@pxref{GDB/MI, ,The @sc{gdb/mi} Interface}), most of
+these commands will fail with an error, because it would not be
+possible or desirable to enable curses window management.
+
 @table @code
 @item info win
 @kindex info win



More information about the Gdb-patches mailing list