New ARI warning Wed May 26 01:54:51 UTC 2010

[Joel Brobecker]

> > > gdb/python/py-cmd.c:192: Â  Â  Â  Â error ("%s", msg);
> > >
> > 
> > There were already a couple of uses of error ("%s", ...) so I figured
> > it was safe.
> 
>   Of course, translation of "%s" into another language does make sense!
>  
> > OOC, is this why source.c has:
> > 
> > error (("%s"), msg);
> 
>   I suspect that the braces around "%s" are exactly here for that reason:
> they avoid getting this ARI report.
>   Does anyone have another idea of the utility of such a wrapping?
> 
>   I could probably try to improve the ARI rule 
> so that it does not complain if the string is just "%s",
> but I would like to be sure that I am not missing some information here.

I don't think anyone really answered the above. I don't see any issue
either way, and I don't have a preference. ISTM that the simplest would
probably be to use ("%s"), instead of adding an exception for "%s".

-- 
Joel