[Oleg Nesterov] PATCH? gdb remote.c: readchar() should pop_target() if SERIAL_ERROR?

Tom Tromey tromey@redhat.com
Wed Jul 28 17:28:00 GMT 2010


>>>>> "Michael" == Michael Snyder <msnyder@vmware.com> writes:

Michael> Tom Tromey wrote:
>> I am forwarding this from the archer list because I think this report is
>> reasonably complete -- I couldn't really improve on it.
>> 
>> Please comment on this patch.  I don't know this area of gdb well.
>> 
>> If the enclosed has insufficient information, please contact me and I
>> will get whatever is needed.  Thanks.

Michael> I'm sorry I haven't been able to recall how I've encountered this
Michael> symptom, so I can't provide a meaningful review.

Michael> Is there a chance of getting this into the 7.2 release?

The change seems correct to me, and I'm interested in getting it in.
But since I don't know this code well I am reluctant to commit it
without someone else's ok.  If that isn't forthcoming I will try to look
into the code more deeply and see if I can figure it out.  Maybe I can
do some kind of failure injection to see the bug live.

Tom



More information about the Gdb-patches mailing list