[RFC 1/6] Rename `enum target_signal' to target_signal_t
Daniel Jacobowitz
dan@codesourcery.com
Tue Jul 27 13:20:00 GMT 2010
On Tue, Jul 27, 2010 at 12:51:08AM +0200, Jan Kratochvil wrote:
> I would fill-in the gdb/ ChangeLog if the patch'es idea does not get rejected.
> I understand the order is not right. Writing the ChangeLog will be a very
> costly task that could get dropped in several seconds of a first review.
Not much is wrong with the changelog you've got. I'd even do:
* gdb/signals.h (target_signal_t): New typedef, from enum
target_signal. All uses updated.
Or:
* gdb/signals.h (target_signal_t): New typedef, from enum
target_signal.
* aix-thread.c, amd64-linux-tdep.c, [all other files]: All uses
updated.
Doing anything more than that is IMO unnecessary.
--
Daniel Jacobowitz
CodeSourcery
More information about the Gdb-patches
mailing list