[RFA] Fix setting of VSX registers
Tom Tromey
tromey@redhat.com
Thu Jul 22 16:06:00 GMT 2010
>>>>> "Thiago" == Thiago Jung Bauermann <bauerman@br.ibm.com> writes:
Thiago> The problem is, the function was "fetching" the VSX registers using
Thiago> PTRACE_SETVSXREGS instead of PTRACE_GETVSXREGS. Ouch.
I don't know this code at all, but this change seems obviously ok to me.
Thiago> This patch fixes the typo, and also fixes the vsx-regs.exp testcase to
Thiago> use gdb_test instead of send_gdb (this also fixes some synchronization
Thiago> issues in the test), and updates the expect info reg output with the new
Thiago> v2_double member.
I don't understand why the new gdb_test calls have an empty "message"
argument.
Actually, this code in gdb_test itself looks somewhat bogus.
Aside from parsing arguments by hand (why??), it uses a different
default for the message than gdb_test_multiple. I don't understand when
this can ever be the right thing to do.
For your patch I suggest just leaving off the 3rd argument.
Also, when the second argument to gdb_test is the empty string ... I
suspect you actually want to use gdb_test_no_output.
Tom
More information about the Gdb-patches
mailing list