[PATCH]prec: record_arch_list_add_mem add check for len

Pedro Alves pedro@codesourcery.com
Tue Jul 20 12:51:00 GMT 2010


On Monday 19 July 2010 09:08:17, Hui Zhu wrote:
> Add this check for some code maybe len < 0.

How can len < 0 happen?  Wouldn't that be a bug?

> 
> Thanks,
> Hui
> 
> 2010-07-16  Hui Zhu  <teawater@gmail.com>
> 
> 	* record.c (record_arch_list_add_mem): Add check for len.
> 
> 
> ---
>  record.c |    2 ++
>  1 file changed, 2 insertions(+)
> 
> --- a/record.c
> +++ b/record.c
> @@ -497,6 +497,8 @@ record_arch_list_add_mem (CORE_ADDR addr
> 
>    if (!addr)	/* FIXME: Why?  Some arch must permit it... */
>      return 0;
> +  if (len <= 0)
> +    return 0;
> 
>    rec = record_mem_alloc (addr, len);
> 


-- 
Pedro Alves



More information about the Gdb-patches mailing list