ping: [patch 3/6] PIE: Fix occasional error attaching i686 binary
Joel Brobecker
brobecker@adacore.com
Mon Jul 5 17:18:00 GMT 2010
> gdb/
> 2010-07-04 Jan Kratochvil <jan.kratochvil@redhat.com>
> Joel Brobecker <brobecker@adacore.com>
>
> * auxv.c (memory_xfer_auxv): Update attach comment.
> * solib-svr4.c (svr4_special_symbol_handling): Remove the call to
> svr4_relocate_main_executable.
> (svr4_solib_create_inferior_hook): Make the call to
> svr4_relocate_main_executable unconditional.
>
> gdb/testsuite/
> 2010-07-04 Jan Kratochvil <jan.kratochvil@redhat.com>
>
> * gdb.base/attach-pie-misread.exp, gdb.base/attach-pie-misread.c: New.
> * gdb.base/break-interp.exp (reach, test_core, test_ld): Require each
> displacement message exactly once.
OK - just one ooopsie:
> --- a/gdb/auxv.c
> +++ b/gdb/auxv.c
> @@ -209,7 +209,14 @@ memory_xfer_auxv (struct target_ops *ops,
>
> /* ld_so_xfer_auxv is the only function safe for virtual executables being
> executed by valgrind's memcheck. As using ld_so_xfer_auxv is problematic
> - during inferior startup GDB does call it only for attached processes. */
> + during inferior startup as ld.so symbol tables are not yet relocated GDB
> + calls ld_so_xfer_auxv only for attached processes. */
> +
> + /* ld_so_xfer_auxv is the only function safe for virtual executables being
> + executed by valgrind's memcheck. Using ld_so_xfer_auxv during inferior
> + startup is problematic, because ld.so symbol tables have not yet been
> + relocated. So GDB uses this function only when attaching to a process.
> + */
You forgot to remove the old version of the comment. :-)
--
Joel
More information about the Gdb-patches
mailing list