[PATCH] Disconnected tracing

Tom Tromey tromey@redhat.com
Wed Jan 6 19:45:00 GMT 2010


>>>>> "Stan" == Stan Shebs <stan@codesourcery.com> writes:

Stan> This next patch realizes a long-anticipated advantage of tracepoints,
Stan> namely that it should be possible to disconnect GDB from the target
Stan> but leave the trace experiment running, then reconnect later to see if
Stan> anything interesting turned up.

A couple little nits...

Stan> + extern void create_tracepoint_from_upload (int num, enum bptype type,
Stan> + 					   ULONGEST addr);

Could this be in a header?  And then the declaration in
remote_get_tracing_state removed?

Maybe this is another of those "will be fixed by the target vector"
oddities.

Stan> + extern void
Stan> + create_tracepoint_from_upload (int num, enum bptype type, ULONGEST addr)
Stan> + {

It is weird to have "extern" on a definition.

Tom



More information about the Gdb-patches mailing list