[RFA] More linespec quoting "fixes"

Keith Seitz keiths@redhat.com
Wed Feb 24 22:49:00 GMT 2010


On 02/24/2010 02:10 PM, Keith Seitz wrote:

> * linespec.c (decode_line_1): Update comments for is_quote_enclosed.
> If the filename portion of the linespec was quoted, recheck the
> remainder for additional quoting.
> (locate_first_half): Skip over completer chars, too.

And, of course, there is a small typo in the patch... locate_first_half 
should be:

@@ -1056,7 +1066,14 @@ locate_first_half (char **argptr, int *i
        p++;
      }
    else
-    *is_quote_enclosed = 0;
+    {
+      *is_quote_enclosed = 0;
+      if (strchr (get_gdb_completer_quote_characters (), *p))
+	{
+	  ++(*argptr);
+	  ++p;
+	}
+    }
    for (; *p; p++)
      {
        if (p[0] == '<')

Sorry about that. FWIW, I've attached the corrected patch as well.

Keith
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: more-linespec-quoting.patch
URL: <http://sourceware.org/pipermail/gdb-patches/attachments/20100224/137675c6/attachment.ksh>


More information about the Gdb-patches mailing list