[RFA] More linespec quoting "fixes"
Keith Seitz
keiths@redhat.com
Wed Feb 24 22:10:00 GMT 2010
Hi,
Daniel recently committed a patch which fixed a couple of linespec
inconsistencies (allow "file:'function'" and "'file:function'").
I wonder why not also allow "'file':function" and "'file':'function'"?
I couldn't find a good answer as to why these two forms would be
disallowed, so I'm submitting the attached patch to enable these formats.
This also fixes some regressions/conflicts that Daniel's patch had with
my (uncommitted) dwarf2_physname patch which touched linespecs. :-)
No regressions on x86-linux.
Keith
PS. This code must die.(TM)
ChangeLog
2010-02-24 Keith Seitz <keiths@redhat.com>
* linespec.c (decode_line_1): Update comments for is_quote_enclosed.
If the filename portion of the linespec was quoted, recheck the
remainder for additional quoting.
(locate_first_half): Skip over completer chars, too.
testsuite/ChangeLog
2010-02-24 Keith Seitz <keiths@redhat.com>
* gdb.cp/overload.exp: Test that the filename portion of a linespec
can be quoted. Test that both the filename and function/line portions
can be quoted at the same time.
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: more-linespec-quoting.patch
URL: <http://sourceware.org/pipermail/gdb-patches/attachments/20100224/36361029/attachment.ksh>
More information about the Gdb-patches
mailing list