PATCH: Generate set_tdesc_osabi for valid OSABI

Daniel Jacobowitz dan@codesourcery.com
Thu Feb 4 17:06:00 GMT 2010


On Thu, Feb 04, 2010 at 08:54:59AM -0800, H.J. Lu wrote:
> On Thu, Feb 4, 2010 at 8:04 AM, Daniel Jacobowitz <dan@codesourcery.com> wrote:
> > On Thu, Feb 04, 2010 at 07:49:10AM -0800, H.J. Lu wrote:
> >> 2010-02-04  H.J. Lu  <hongjiu.lu@intel.com>
> >>
> >>       * target-descriptions.c (maint_print_c_tdesc_cmd): Generate
> >>       set_tdesc_osabi for valid OSABI.
> >
> > This patch would require regenerating the board files after changing
> > the enum.  If we have to hard-code the value, there should be a
> > warning to only add new items to the end of the enum unless
> > regenerating the files.
> >
> 
> Good point. How about using OSABI string instead?

Nice trick.  Yes, this is fine.

-- 
Daniel Jacobowitz
CodeSourcery



More information about the Gdb-patches mailing list