Revised pr 9067 patch

[Chris Moller]

On 02/03/10 17:21, Tom Tromey wrote:
>>>>>> "Chris" == Chris Moller<cmoller@redhat.com>  writes:
>>>>>>              
>
> Chris>  Fixes "Nested static causing infinite recursion in print."
>
> There are still the formatting nits that I mentioned on the last
> go-round.
>
> Chris>  +      void * statmem_obstack_top = NULL;
>
> No space after *.
>
> Chris>  +	  /* set the current printed-statics stack top */
>
> Comments in the GNU style are sentences.  They start with a capital
> letter and end with a period and two spaces.
>
> Chris>  +	  /* In effect, a pop of the printed-statics stack */
>
> Ditto.
>
> Chris>  +      first_dont_print = (CORE_ADDR *)obstack_base (&dont_print_statmem_obstack);
>
> Line goes past column 79?  It seems to but sometimes it is hard to tell
> in a patch.  Space after the closing paren of the cast.
>
> Chris>  +      i = obstack_object_size (&dont_print_statmem_obstack) / sizeof(CORE_ADDR);
>
> Space after sizeof.  Too many columns, should line break.
>
> Tom
>    

-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: pr9067.patch
URL: <http://sourceware.org/pipermail/gdb-patches/attachments/20100204/2d133d7c/attachment.ksh>