patch for crash in d-lang.c's demangler
Brad Roberts
braddr@puremagic.com
Tue Aug 10 23:15:00 GMT 2010
On Tue, 10 Aug 2010, Tom Tromey wrote:
> >>>>> "Brad" == Brad Roberts <braddr@puremagic.com> writes:
>
> I think your patch is reasonable, but the line just after your change is
> weird:
>
> > if (i <= 0 && strlen (mangled_str) < i)
> > return 0;
>
> I don't think that condition can ever be true.
Agreed. Your patch looks good. I feel guilty about not contributing a
unit test to cover this case, so I shouldn't poke you about not adding one
either, but if you feel like feeling that guilty... :)
Thanks,
Brad
More information about the Gdb-patches
mailing list