[RFA] Prepare for Mingw Windows 64-bit gdbserver
Pierre Muller
pierre.muller@ics-cnrs.unistra.fr
Mon Apr 19 06:37:00 GMT 2010
> > -srv_amd64_regobj="amd64.o x86-64-avx.o"
> > +srv_amd64_regobj="amd64.o amd64-avx.o"
>
> looks like another piece. Is it just a cosmetic change because
> we use amd64 instead of x86-64 throughout? Please explain
> it and post it separately, if possible.
I suspect that this is an error in the commit
from H.J. Lu dated 2010/04/07.
The ChangeLog says:
* configure.srv (srv_i386_regobj): Add i386-avx.o.
(srv_i386_linux_regobj): Add i386-avx-linux.o.
(srv_amd64_regobj): Add amd64-avx.o.
But
$ cvs diff -r 1.51 -r 1.52 configure.srv
Index: configure.srv
===================================================================
RCS file: /cvs/src/src/gdb/gdbserver/configure.srv,v
retrieving revision 1.51
retrieving revision 1.52
diff -r1.51 -r1.52
25,28c25,28
< srv_i386_regobj=i386.o
< srv_i386_linux_regobj=i386-linux.o
< srv_amd64_regobj=amd64.o
< srv_amd64_linux_regobj=amd64-linux.o
---
> srv_i386_regobj="i386.o i386-avx.o"
> srv_i386_linux_regobj="i386-linux.o i386-avx-linux.o"
> srv_amd64_regobj="amd64.o x86-64-avx.o"
> srv_amd64_linux_regobj="amd64-linux.o amd64-avx-linux.o"
30,35c30,35
As srv_amd64_regobj is not yet used, nobody noticed it before
I tried to use it for mingw64 support.
Is this OK?
Pierre
PS: I will try to send the patch into several sub-patches,
but I am still not used to handling patch series ...
ChangeLog entry:
2010-04-19 Pierre Muller <muller@ics.u-strasbg.fr>
* configure.srv (srv_amd64_regobj): Replace `x86-64-avx.o' by
`amd64-avx.o'.
Index: configure.srv
===================================================================
RCS file: /cvs/src/src/gdb/gdbserver/configure.srv,v
retrieving revision 1.53
diff -u -p -r1.53 configure.srv
--- configure.srv 8 Apr 2010 22:32:38 -0000 1.53
+++ configure.srv 18 Apr 2010 15:34:29 -0000
@@ -24,7 +24,7 @@ srv_hostio_err_objs="hostio-errno.o"
srv_i386_regobj="i386.o i386-avx.o i386-mmx.o"
srv_i386_linux_regobj="i386-linux.o i386-avx-linux.o i386-mmx-linux.o"
-srv_amd64_regobj="amd64.o x86-64-avx.o"
+srv_amd64_regobj="amd64.o amd64-avx.o"
srv_amd64_linux_regobj="amd64-linux.o amd64-avx-linux.o"
srv_i386_32bit_xmlfiles="i386/32bit-core.xml i386/32bit-sse.xml
i386/32bit-avx.xml"
More information about the Gdb-patches
mailing list