[PATCH] disassemble support start,+length format

Eli Zaretskii eliz@gnu.org
Thu Apr 15 17:08:00 GMT 2010


> From: crquan@gmail.com
> Cc: Hui Zhu <teawater@gmail.com>,
> 	Joel Brobecker <brobecker@adacore.com>,
> 	Eli Zaretskii <eliz@gnu.org>
> Date: Thu, 15 Apr 2010 15:50:36 +0800
> 
> add new support for disassemble by "start,+length" format;
> 
> update ChangeLog,NEWS,doc/gdb.texinfo accordingly.
> BTW, I found two disassemble Changes in GDB 7.0 in NEWS, separated in two
> paragraphs, so I merged them into one.

Thanks.

>  gdb-7.1.50.20100415/gdb/ChangeLog       |    8 +++++++-
>  gdb-7.1.50.20100415/gdb/NEWS            |   13 ++++++++-----
>  gdb-7.1.50.20100415/gdb/cli/cli-cmds.c  |   18 +++++++++++++++---
>  gdb-7.1.50.20100415/gdb/doc/gdb.texinfo |   28 ++++++++++++++++++++++++++--
>  4 files changed, 56 insertions(+), 11 deletions(-)

Please also add an entry in gdb/doc/ChangeLog regarding the changes in
gdb/doc/gdb.texinfo.

> +@smallexample
> +(gdb) disas /r main,+20
> +Dump of assembler code from 0x450670 to 0x450684:
> +   0x0000000000450670 <main+0>:	 48 83 ec 28	sub    $0x28,%rsp
> +   0x0000000000450674 <main+4>:	 48 c7 04 24 00 00 00 00	movq   $0x0,(%rsp)
> +   0x000000000045067c <main+12>:	 89 3c 24	mov    %edi,(%rsp)
> +   0x000000000045067f <main+15>:	 48 89 e7	mov    %rsp,%rdi
> +   0x0000000000450682 <main+18>:	 48 c7 44 24 10 00 00 00 00	movq   $0x0,0x10(%rsp)
> +End of assembler dump.
> +@end smallexample

This is okay, but any line inside @smallexample block that is longer
than 72 characters will overflow the page margins in the printed
version of the manual.  So could you perhaps select an example with
shorter lines?

Okay with that change.



More information about the Gdb-patches mailing list