[PATCH] disassemble support start,+length format
Tom Tromey
tromey@redhat.com
Fri Apr 9 18:14:00 GMT 2010
>>>>> ">" == crquan <crquan@gmail.com> writes:
>> From: CHENG Renquan <rqcheng@smu.edu.sg>
>> add new support for disassemble by "start,+length" format;
Do you have a copyright assignment in place?
If not, let me know and I can get you started.
>> /* Two arguments. */
>> + int incl_flag = 0;
>> +
>> low = pc;
I think you should skip whitespace here.
>> + if (arg[0] == '+') {
The brace placement is wrong here. See the GNU Coding Standards, or
existing code in that function.
Otherwise this seems reasonable to me.
Tom
More information about the Gdb-patches
mailing list