[patch] Fix dangling displays in separate debug

Jan Kratochvil jan.kratochvil@redhat.com
Fri Apr 9 15:53:00 GMT 2010


On Fri, 09 Apr 2010 17:34:01 +0200, Pedro Alves wrote:
> On Friday 09 April 2010 16:30:14, Jan Kratochvil wrote:
> > Unaware how to improve it more.
> 
> Would using objfile_separate_debug_iterate be better?

In this case we are examining `struct expression *'.
EXP contains `struct symbol *'.
SYMBOL points to `struct objfile *' of the separate debug info file.

If SYMBOL points to `struct objfile *' of the main binary, it is equal to
SOLIB->OBJFILE and it has been already checked before.

The main binary -> separate debug info direction provided by the iterating
functionality of objfile_separate_debug_iterate is not useful in this case.


I cannot not say I like this design but its rework I have not completed to the
check-in before:
	[patch 1/8] Types GC [unloading observer]
	http://sourceware.org/ml/gdb-patches/2009-05/msg00544.html
	Re: [patch 3/8] Types GC [display_uses_solib_p to exp_iterate]
	http://sourceware.org/ml/gdb-patches/2009-07/msg00054.html

If continuing hacks of the current code is not acceptable it can wait till / I
can push the proper reimplementation of this code from the old thread above.



Thanks,
Jan



More information about the Gdb-patches mailing list