[PATCH] Use vectors in uploaded tracepoints

Stan Shebs stan@codesourcery.com
Mon Apr 5 19:46:00 GMT 2010


This patch changes the arrays of uploaded tracepoints into vectors, 
clearing out some silly arbitary limits.

Despite being pretty obvious, I'm not committing immediately, because I 
have a couple questions.

1. This is now the third place that has a "char_ptr" typedef for use 
with vectors.  Is there any reason not to consolidate into one typedef 
in defs.h?

2. Should it be renamed to "char_p"?  There is a quasi-standard of using 
"_s" for struct and "_p" for pointer typedefs for vectors; but "char_p" 
seems a little cryptic to me.

Stan

2010-04-05  Stan Shebs  <stan@codesourcery.com>

    * tracepoint.h (struct uploaded_string): Remove.
    (char_ptr): Define.
    (struct uploaded_tp): Use vectors for string arrays.
    * tracepoint.c (trace_save): Use vectors of actions.
    (parse_tracepoint_definition): Ditto.
    (get_uploaded_tp): Clear vectors.
    * breakpoint.c (create_tracepoint_from_upload): Use vectors.
    (next_cmd): Change to an int.
    (read_next_cmd): Use vector of command strings.



-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: actvec-patch-1
URL: <http://sourceware.org/pipermail/gdb-patches/attachments/20100405/c855d367/attachment.ksh>


More information about the Gdb-patches mailing list