[patch] Speed up find_pc_section

Joel Brobecker brobecker@adacore.com
Fri Sep 11 21:15:00 GMT 2009


> 2009-09-11  Paul Pluzhnikov  <ppluzhnikov@google.com>
> 
>      * objfiles.c (qsort_cmp): Remove asserts.
>      (insert_section_p, filter_debuginfo_sections): New function.
>      (filter_overlapping_sections): Likewise.
>      (update_section_map): Adjust.

Looks great to me. Please go ahead and commit.

> +	      complaint (&symfile_complaints,
> +			 _("unexpected overlap between (A) "
> +			   "section `%s' from `%s' [%s, %s) and (B) "
> +			   "section `%s' from `%s' [%s, %s). "
> +			   "Will ignore section B"),
> +			 bfd_section_name (abfd1, bfds1), objf1->name,
> +			 paddress (gdbarch, sect1_addr),
> +			 paddress (gdbarch, sect1_endaddr),
> +			 bfd_section_name (abfd2, bfds2), objf2->name,
> +			 paddress (gdbarch, sect2_addr),
> +			 paddress (gdbarch, sect2_endaddr));

Just one question: Do you think it might be advantageous to split
this complaint in multiple lines? Something like:
                  _("\
unexpected overlap between:\n\
  (A) section `%s' from ...\n\
  (B) section `%s' from ...\n\
Will ignore section B")

Just a thought... If others think so, I will make the change after
you commit your patch. You've already gone beyond the call of duty
on this one.

-- 
Joel



More information about the Gdb-patches mailing list