[RFA/PATCH] PR/9711: quadratic slowdown for deep stack traces
Pedro Alves
pedro@codesourcery.com
Mon Sep 7 20:57:00 GMT 2009
On Monday 07 September 2009 21:33:21, Joel Brobecker wrote:
> > Nit: It seems like there's a redundant call to frame_id_eq in frame_find_by_id.
>
> Ooops, you're right. Thanks for catching this! Here is a new patch.
> I used "frame_stash" to avoid the confusion with the "cache" terminology
> used in that unit.
>
> Currently testing on x86_64-linux...
>
Hmmm, nowhere in the patch is the actual reason this is
needed explained. Could you have some of that?
+ /* Try using the frame cache first. */
+ frame = frame_stash_find (id);
+ if (frame)
+ return frame;
I guess here would be a good place to explain it. At least update
the comment to refer to stash instead of cache. :-)
--
Pedro Alves
More information about the Gdb-patches
mailing list