RFC: DW_OP_call_frame_cfa, again

Pedro Alves pedro@codesourcery.com
Tue Sep 1 23:24:00 GMT 2009


On Tuesday 01 September 2009 19:08:25, Tom Tromey wrote:
> 
> +/* CFA accesses require a frame.  */
> +static CORE_ADDR
> +needs_frame_frame_cfa (void *baton)
> +{
> +  struct needs_frame_baton *nf_baton = baton;
> +  nf_baton->needs_frame = 1;
> +  return 1;
> +}
> +

Return type is CORE_ADDR, but it returns 1?

On Tuesday 01 September 2009 19:08:25, Tom Tromey wrote:
> +/* Return true if the frame unwinder for frame FI is UNWINDER; false
> +   otherwise.  */
> +
> +extern int frame_unwinder_is (struct frame_info *fi,
> +                             const struct frame_unwind *unwinder);


> +/* Return true if the frame base for frame FI is BASE; false
> +   otherwise.  */
> +
> +int
> +frame_unwinder_is (struct frame_info *fi, const struct frame_unwind *unwinder)
> +{

Stale comment.

-- 
Pedro Alves



More information about the Gdb-patches mailing list