[RFA] Expand "info record"

[Michael Snyder]

Pedro Alves wrote:
> On Tuesday 20 October 2009 23:25:30, Michael Snyder wrote:
> 
>>>> +      /* Display instruction number for last instruction in the log.  */
>>>> +      printf_filtered (_("Highest recorded instruction number is %llu.\n"), 
>>>> +                      record_insn_count ? record_insn_count - 1 : 0);
>>> Why the conditional subtraction?
>> Because I don't want it to say "-1".
> 
> Okay, that much is obvious, but how can you reach here
> with record_insn_count == 0, given that you check if you
> have a log at all a bit above?

Maybe not -- but I'm a belt-and-suspenders guy.
I don't believe in not checking for something just because
it "can't happen".  What if somebody changed the check above?

[...]
> 
> Can't we explicitly say that we're in recording/live vs replay
> mode, or something?

Yeah, you've convinced me.  Thanks for the prodding,
and please see new revision.  I'll make that conditional
go away too.   ;-)

-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: info4.txt
URL: <http://sourceware.org/pipermail/gdb-patches/attachments/20091021/e3e6c7d8/attachment.txt>