[RFA, 5 of 3] save/restore process record, part 5 (gcore change)
Michael Snyder
msnyder@vmware.com
Mon Oct 19 20:12:00 GMT 2009
Tom Tromey wrote:
>>>>>> "Michael" == Michael Snyder <msnyder@vmware.com> writes:
>
> Michael> +/* create_gcore_bfd -- helper for gcore_command (exported). */
>
> Michael> +bfd *
> Michael> +create_gcore_bfd (char *filename)
>
> That comment is not very descriptive.
>
> Michael> +/* write_gcore_file -- helper for gcore_command (exported). */
> Michael> +
> Michael> +void
> Michael> +write_gcore_file (bfd *obfd)
>
> Likewise.
>
> Michael> Index: gcore.h
> Michael> ===================================================================
> Michael> RCS file: gcore.h
> Michael> diff -N gcore.h
>
> The gdb internals document says that headers should have include guards.
OK. Also, I found that I had included some code in this patch
that I didn't need -- so this version is shorter. ;-)
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: gcorepb.txt
URL: <http://sourceware.org/pipermail/gdb-patches/attachments/20091019/e2536065/attachment.txt>
More information about the Gdb-patches
mailing list