[patch] Add cleanup branch for std::terminate breakpoints in call_function_by_hand
Joel Brobecker
brobecker@adacore.com
Thu Oct 1 16:44:00 GMT 2009
> 2009-10-01 Phil Muldoon <pmuldoon@redhat.com>
>
> * infcall.c (call_function_by_hand): Add a new cleanup branch for
> std::terminate breakpoint.
This is OK for the HEAD, except for one minor tiny comment:
> + struct cleanup *terminate_bp_cleanup;
Can you initialize this to NULL? I know from code inspection that
you cannot use it uninitialized, but you never know. Plus some compilers
may not be smart enough to detect that...
Thanks,
--
Joel
More information about the Gdb-patches
mailing list